Max weeks to 48 is not enforced

[JocelynDelalande]

Steps to reproduce :

1. Configure a form in external mode with 48 weeks visibility
2. Try to book an appointment

What is expected ?

As of now (10/1/2024) I should be able to book for slots up to next december 2024

What happens ?

I can only go as far as may 2024 (~18 weeks)

Context

• Appointments app v1.15.3
• NextCloud 26.0.7
• Contributor key

[JocelynDelalande]

I can confirm it's ~18 weeks ahead. As of now we can book up to May 23th.

[SergeyMosin]

The bug(regression) is actually here:

Appointments/lib/Backend/BCSabreImpl.php

Lines 301 to 304 in a13534f

	$c++;
	if ($c > 128) {
	break;
	}

In External Mode there is a limit of 128 appointments per request, this limit was not adjusted when 32,40,48 weeks visibilities were added.

This will be fixed in v2, as it will have a different API for fetching available appointments.

Thank you for the report.

[JocelynDelalande]

Thanks for the detailed answer :).

Meanwhile, would a patch that manually raises the limit to something higher (512 ?) in the code do the job ?

[SergeyMosin]

Fixed in v2.1.12