Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booked Appointment Buffers (Should take into account existing conflicts) #328

Closed
rightsaidfred99 opened this issue May 8, 2022 · 8 comments

Comments

@rightsaidfred99
Copy link

Hello,

The new Booked Appointment buffers is great!
However It does not seem to work for "After" with existing conflict when source is Google Calendar.

So if I have a 1hour booking at 2pm with 30 minutes in between bookings.

Client should only be allowed to next book 3:30pm.

Currently, the app only reads the start point thus currently a client can actually book 3pm despite there being a 30 minute buffer on the "After" option.

Hope that makes sense.

I just propose that the app takes into consideration the length of the existing calendar event with Google Calendar

@SergeyMosin
Copy link
Owner

At the moment buffers only apply to confirmed ( or pending ) appointments (events) that were created by the appointments app. The reasoning is that only appointments would require buffers for something like prep or clean up, and user created blockers can be of some other type of event (birthday party or business lunch ) for which buffers are not needed or user who created them would account for the buffer time already.

However, in the future anUse buffers for all blockers option can be added.

@rightsaidfred99
Copy link
Author

Buffers for all option would be awesome.

Many times clients send me ICS invites which I accept, so to have appointments buffer time from existing appointments would be awesome

@mbscala
Copy link

mbscala commented Apr 5, 2023

Hi @SergeyMosin , do you accept any sponsorships to move up certain issues in the timeline?

This issue would be very important for me, as it decides about whether I can or cannot use the Appointments app for productive use.

I have many calendars and also many ways of arranging appointments, the Appointments app is just one way so it would be crucial for me that the Appointments app considers the configured buffers for ALL conflicts in ALL selected calendars. Basically, whenever I create an event in any of my "conflict" calendars that lists me as "busy", this should be considered in the configured buffers scheme.

I have already contributed on your donations page, but would be happy to contribute again if there was any chance to move forward with this very important issue.

Thank you for your great app!

@SergeyMosin
Copy link
Owner

If I remember correctly some test failed on subscription/external (google, office360) calendars. I'll circle back to this over the weekend and see if at least NC native calendar events can be included into the "buffer check".

@mbscala
Copy link

mbscala commented Apr 5, 2023

That would be great! At least for my part I am only using native NC calendars, therefore such a fix would be a great improvement for me :) Thank you!

@sschachamayr
Copy link

Also very interested, I'm using nc calendar as the main 'conflict-base'
Many thanks to @SergeyMosin
Regards from Austria

@SergeyMosin
Copy link
Owner

Buffers apply to ALL blocking events as of v1.14.14

@mbscala
Copy link

mbscala commented Apr 10, 2023

Thank you so much @SergeyMosin ! Just left another contribution, this really is a great improvement for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants