AK: Enable format string checking in Clang builds #24400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
This is unexpected, to say the least: |
github-actions
bot
removed
the
👀 pr-needs-review
|
That workaround looks fine to me if you want to just fixup the commit message |
There was an issue with Clang that causes `consteval` function calls from default initializers of fields to be made at run-time. This manifested itself in the case of `ByteString::formatted` as an undefined reference to `check_format_parameter_consistency` once format string checking was enabled for Clang builds. The workaround is simple (just move it to the member initializer list), and unblocks a useful change.
Format string checking was disabled in Clang-based builds due to a compiler bug: llvm/llvm-project#51182. Now that the requirement has been raised to Clang 17, that is no longer necessary. This has been tested to work correctly with Apple Clang 15.0.0 (which is the *least modern* supported compiler), as well as CLion 2024.1's bundled Clangd.
github-actions
bot
added
the
👀 pr-needs-review
ADKaster
approved these changes
May 29, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format string checking was disabled in Clang-based builds due to a compiler bug: llvm/llvm-project#51182. Now that the requirement has been raised to Clang 17, that is no longer necessary.
This has been tested to work correctly with Apple Clang 15.0.0 (which is the least modern supported compiler), as well as CLion 2024.1's bundled Clangd.