Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind helper RFC changes #18

Closed
Windvis opened this issue Jul 19, 2019 · 1 comment · Fixed by #19
Closed

Bind helper RFC changes #18

Windvis opened this issue Jul 19, 2019 · 1 comment · Fixed by #19

Comments

@Windvis
Copy link

Windvis commented Jul 19, 2019

Since the v3 alfa release the bind helper RFC has been changed. The helper has been renamed to fn and no longer provides any context binding functionality.

Since a polyfill for the fn helper already exists and it is part of Ember since 3.11 I think it might be better to remove the deprecation notice in the readme?

Having a bind helper can still be useful for use cases that the @action decorator + fn don't cover. For ex. Calling methods on third party classes you don't control.

Serabe added a commit that referenced this issue Jul 19, 2019
Serabe added a commit that referenced this issue Jul 19, 2019
@Serabe
Copy link
Owner

Serabe commented Jul 19, 2019

Fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants