Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promethius config #620

Closed
SimonMcN opened this issue Nov 3, 2022 · 1 comment · Fixed by #622
Closed

Promethius config #620

SimonMcN opened this issue Nov 3, 2022 · 1 comment · Fixed by #622

Comments

@SimonMcN
Copy link

SimonMcN commented Nov 3, 2022 •
edited
Loading

I think that the file ./volumes/prometheus/data/config/config.yml may be incorrect but I leave it to your judgement.

I think that cadvisor needs to be the name of the container, in this case prometheus-cadvisor. I have made the changes below and they all now show as UP in my local instance @ http://iotstack:9090/targets

scrape_configs:

  • job_name: "iotstack"
    static_configs:
    • targets:
      • localhost:9090
      • cadvisor:8080
      • nodeexporter:9100
      • prometheus-cadvisor:8080
      • prometheus-nodeexporter:9100
@Paraphraser
Copy link

I believe you are correct. I am going to submit some pull requests to deal with this. Thanks for reporting it.

Paraphraser added a commit to Paraphraser/IOTstack that referenced this issue Nov 8, 2022
@Paraphraser
2022-11-08 Prometheus defaults - master branch - PR 1 of 3
30dd48f 
Per issue SensorsIot#620, the default `config.yml` should reference:

	- `prometheus-cadvisor:8080` not `cadvisor:8080`
	- `prometheus-nodeexporter:9100` not `nodeexporter:9100`

Master branch doco updated to add migration tips.

Fixes SensorsIot#620

Signed-off-by: Phill Kelley <[email protected]>
@Paraphraser Paraphraser mentioned this issue Nov 8, 2022
Merged
Paraphraser added a commit to Paraphraser/IOTstack that referenced this issue Nov 8, 2022
@Paraphraser
2022-11-08 Prometheus defaults - old-menu branch - PR 2 of 3
3ea450d 
Per issue SensorsIot#620, the default `config.yml` should reference:

	- `prometheus-cadvisor:8080` not `cadvisor:8080`
	- `prometheus-nodeexporter:9100` not `nodeexporter:9100`

Signed-off-by: Phill Kelley <[email protected]>
@Paraphraser Paraphraser mentioned this issue Nov 8, 2022
Merged
Paraphraser added a commit to Paraphraser/IOTstack that referenced this issue Nov 8, 2022
@Paraphraser
2022-11-08 Prometheus defaults - experimental branch - PR 3 of 3
b227a1c 
Per issue SensorsIot#620, the default `config.yml` should reference:

	- `prometheus-cadvisor:8080` not `cadvisor:8080`
	- `prometheus-nodeexporter:9100` not `nodeexporter:9100`

Signed-off-by: Phill Kelley <[email protected]>
@Paraphraser Paraphraser mentioned this issue Nov 8, 2022
Merged
@Slyke Slyke closed this as completed in #622 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2022-11-08 Prometheus defaults - master branch - PR 1 of 3 Paraphraser/IOTstack
1 participant
@Paraphraser