Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code and modules because of module changes #173

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Mar 23, 2024

This PR does the following:

  • Updates the code to allow the new paho-mqtt client v2 which had breaking changes.
    Note that the code is still working if one is using the old version (1.6.x)
  • Add code to make the homeassistant status name configurable.
    Supersedes subscribe to homeassistant/status and not hass/status (default values) #168
    No breaking change, if the value is not in the config, the old default (hass) is used
  • Add the ability to configure TLS for MQTT
    Supersedes subscribe to homeassistant/status and not hass/status (default values) #168
    No breaking change if TLS is not defined in the config
  • Add a tls-files directory including a .gitignore file excluding all files from git sync
    This eases adding TLS certificates into a directory that are excluded from repo updates.
  • Updated the requirements.txt file removing module versions + adding one module
    This module is needed to identify a modules version (needed for paho-mqtt).
    • I am running all modules with the latest module release available without any issues.
      Though keeping the version for rpi_bad_power.
  • Update the README accordingly

The code runs flawless on my system (as usual 😄 )

Note, if you merge this, you maybe want to make a new release so that the changes get recognized more easily.

@Sennevds
Copy link
Owner

Hi looks good but you have some conflicts if you can fix these I will merge the branch

@mmattel
Copy link
Contributor Author

mmattel commented Mar 23, 2024

Conflicts solved. Funnily they were only in the repo but not local. Anyways clean now 😄

@Sennevds Sennevds merged commit 7186a1f into Sennevds:master Mar 23, 2024
@mmattel mmattel deleted the updates branch March 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants