Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR adresses #2201: Extra width causing horizontal overflow #2202

Merged
merged 1 commit into from
Apr 22, 2021
Merged

This PR adresses #2201: Extra width causing horizontal overflow #2202

merged 1 commit into from
Apr 22, 2021

Conversation

Meneguini
Copy link
Contributor

@Meneguini Meneguini commented Apr 22, 2021 •
edited
Loading

  • Reduced marginLeft of elements and width of PostInfo on screens
    bigger than 'lg' [PonstInfo.tsx]

Co-authored-by: PedroFonsecaDEV

Issue This PR Addresses

This PR fixes #2201

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • Reduced marginLeft of elements and the width of the root in the PostInfo.tsx
  • Changed the Post.tsx breakpoints from 1200px to 1205px
    Together, these changes eliminated the overflow.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)
    Before:

overflow

After:
overflow-after

@Meneguini @PedroFonsecaDEV
- Changed 1200px breakpoints to 1205px [Post.tsx]
8987146 
- Reduced marginLeft of elements and width of PostInfo on screens
bigger than 'lg' [PonstInfo.tsx]

Co-authored-by: PedroFonsecaDEV <[email protected]>
@PedroFonsecaDEV PedroFonsecaDEV added area: front-end type: bug Something isn't working labels Apr 22, 2021
@PedroFonsecaDEV PedroFonsecaDEV added this to the 2.0 Release milestone Apr 22, 2021
humphd
humphd approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me, thank you.

@PedroFonsecaDEV PedroFonsecaDEV merged commit 742453e into Seneca-CDOT:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanLeeMidori yuanLeeMidori yuanLeeMidori approved these changes

@humphd humphd humphd approved these changes

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

@DukeManh DukeManh Awaiting requested review from DukeManh

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

Assignees

@PedroFonsecaDEV PedroFonsecaDEV

@Meneguini Meneguini

Labels
area: front-end type: bug Something isn't working
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

Extra width causing horizontal overflow
4 participants
@Meneguini @humphd @yuanLeeMidori @PedroFonsecaDEV