Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix banner buttons on mobile #2194

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Fix banner buttons on mobile #2194

merged 2 commits into from
Apr 22, 2021

Conversation

PedroFonsecaDEV
Copy link
Contributor

Issue This PR Addresses

No opened issue.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

We had a regression on our mobile BannerButtons when the SignUp page landed.
This PR fixes this regression.

Production:

Screen Shot 2021-04-20 at 7 51 18 PM

Staging: (buttons in the right size of the screen.)

Screen Shot 2021-04-20 at 7 50 23 PM

With this PR:

Screen Shot 2021-04-20 at 7 50 47 PM

Screen Shot 2021-04-20 at 7 58 34 PM

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@PedroFonsecaDEV PedroFonsecaDEV added this to the 2.0 Release milestone Apr 21, 2021
@PedroFonsecaDEV PedroFonsecaDEV self-assigned this Apr 21, 2021
@PedroFonsecaDEV PedroFonsecaDEV requested a review from humphd April 21, 2021 23:42
humphd
humphd previously approved these changes Apr 22, 2021
View reviewed changes
manekenpix
manekenpix previously approved these changes Apr 22, 2021
View reviewed changes
birtony
birtony previously approved these changes Apr 22, 2021
View reviewed changes
yuanLeeMidori
yuanLeeMidori previously approved these changes Apr 22, 2021
View reviewed changes
@PedroFonsecaDEV
Copy link
Contributor Author

Rebasing and merging.

@PedroFonsecaDEV PedroFonsecaDEV merged commit 4bb4045 into Seneca-CDOT:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanLeeMidori yuanLeeMidori yuanLeeMidori left review comments

@birtony birtony birtony left review comments

@manekenpix manekenpix manekenpix left review comments

@humphd humphd humphd left review comments

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

@DukeManh DukeManh Awaiting requested review from DukeManh

Assignees

@PedroFonsecaDEV PedroFonsecaDEV

Labels
area: front-end
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@PedroFonsecaDEV @humphd @manekenpix @birtony @yuanLeeMidori