Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast ratio in contributor card and search results message #2184

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

yuanLeeMidori
Copy link
Contributor

@yuanLeeMidori yuanLeeMidori commented Apr 20, 2021

Issue This PR Addresses

Fixes: #2049
Fixes: #2168

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Current contributor card in about page (dark mode) doesn't meet AAA rating in WCAG. I change the color to make it meet the requirement.
Before
image
After
image


The messages in search result, "No more posts" and "No results found" has same font and background color, which makes it invisible. I change the font color to make it visible. Please let me know if you have other suggestion of the color choosing, appreciate it.

No more posts
chrome-capture (4)

No results found
chrome-capture (5)

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@yuanLeeMidori yuanLeeMidori added type: bug Something isn't working area: front-end area: accessibility Making Telescope accessible for all kinds of users labels Apr 20, 2021
@yuanLeeMidori yuanLeeMidori added this to the 2.0 Release milestone Apr 20, 2021
@yuanLeeMidori yuanLeeMidori self-assigned this Apr 20, 2021
Copy link
Contributor

@izhuravlev izhuravlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! You can probably squash those commits and LGTM!

Copy link
Contributor

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yuanLeeMidori yuanLeeMidori merged commit bc2fec8 into Seneca-CDOT:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some texts are invisible in search page (dark mode) Improve color contrast in contributor card in dark mode
3 participants