Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker environment for search service #2161

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Apr 16, 2021

We need a few tweaks to our environment for the Search service. The search service needs to be able to talk to Elasticserach via the Docker network, so the domain name has to be the elasticsearch container vs. localhost, or it can't reach outside of its own container. Also, we need to do this in all configurations, not just in dev or production, so I've moved it to docker-compose.yml. Finally, we need to expose the POSTS_URL to the environment of the search service, so that it can construct URLs.

@humphd humphd requested review from izhuravlev and HyperTHD April 16, 2021 02:35
@humphd humphd added area: elasticsearch Elasticsearch Related issues and pull requests type: bug Something isn't working labels Apr 16, 2021
@humphd humphd merged commit 42224d8 into Seneca-CDOT:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: elasticsearch Elasticsearch Related issues and pull requests area: microservices type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants