Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove remaining volumes/images/contaniers in every deployment #2159

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

manekenpix
Copy link
Member

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes the way volumes, containers and images are removed during a deployment.
Previously, remaining containers/volumes/images were removed after the new deployment was completed, but some testing showed that it didn't always work. With this change, unused elements are removed after building the new version of telescope, but before launching it.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added area: deployment Production or Staging deployment area: autodeployment Anything related to auto deployment labels Apr 16, 2021
@manekenpix manekenpix requested review from humphd, c3ho and birtony April 16, 2021 01:26
@manekenpix manekenpix self-assigned this Apr 16, 2021
@manekenpix manekenpix changed the title Fix: Make sure lingering volumes/images/contaniers are removed in every deployment Fix: Make sure remaining volumes/images/contaniers are removed in every deployment Apr 16, 2021
@manekenpix manekenpix changed the title Fix: Make sure remaining volumes/images/contaniers are removed in every deployment Fix: Remove volumes/images/contaniers are removed in every deployment Apr 16, 2021
@manekenpix manekenpix changed the title Fix: Remove volumes/images/contaniers are removed in every deployment Fix: Remove remaining volumes/images/contaniers are removed in every deployment Apr 16, 2021
@manekenpix manekenpix changed the title Fix: Remove remaining volumes/images/contaniers are removed in every deployment Fix: Remove remaining volumes/images/contaniers in every deployment Apr 16, 2021
humphd
humphd previously approved these changes Apr 16, 2021
chrispinkney
chrispinkney previously approved these changes Apr 16, 2021
humphd
humphd previously approved these changes Apr 17, 2021
@manekenpix manekenpix merged commit c6c51cb into Seneca-CDOT:master Apr 17, 2021
@manekenpix manekenpix deleted the fix-deploy-script branch April 17, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: autodeployment Anything related to auto deployment area: deployment Production or Staging deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants