SignUp Page #2148

PedroFonsecaDEV · 2021-04-14T23:38:37Z

Issue This PR Addresses

Fixes #1643
Co-authored-by: @PedroFonsecaDEV
Co-authored-by: @Meneguini
Co-authored-by: @DukeManh

Type of Change

Bugfix: Change which fixes an issue
New Feature: Change which adds functionality
Documentation Update: Change which improves documentation
UI: Change which improves UI

Description

This PR adds the signup page. The style and the design still need to be polished, but we believe that we need to land this feature on our staging serv so we can test with our users (us).
The styles of the page will be fixed in follow-ups.

Checklist

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

humphd · 2021-04-14T23:49:26Z

Tagging some more reviewers. I'd like to prioritize this PR so we can move toward getting the signup flow working in the front-end soon, and have time to fix bugs before 2.0.

huyxgit

is it a page but looks like a dialog?
I think we should give user a chance to go back to homepage other than clicking on "back" button.

PedroFonsecaDEV · 2021-04-15T00:05:35Z

is it a page but looks like a dialog?
I think we should give user a chance to go back to homepage other than clicking on "back" button.

@huynguyez
Follow ups. We are landing the functionality.

yuanLeeMidori

I assume this is part of the sign-up and there will be more follow-up PRs, but should the "Login" button be "Next"? Or, should there be a "Next" button based on the instruction in this page? Or, it'll be in the upcoming PRs?

Great design as usual!

DukeManh · 2021-04-15T01:50:24Z

@yuanLeeMidori, you are right, Pedro will update it. More PRs are coming but feel free to comment on anything.

HyperTHD

Don't forget to add the USERS_URL and the FEED_DISCOVERY_URL as args in both production.yml and the Dockerfile in the root directory, otherwise, you won't be able to test this in staging and production.

humphd

This is so awesome to see, thank you to all of you for pushing on it. I've tested it, and it's generally working. There are things I'd like to improve about wording, UI, but they don't need to block this. I left a few notes about issues, questions, and areas for follow-up.

src/web/next.config.js

src/web/src/components/BannerButtons.tsx

src/web/src/components/SignUp/Forms/BasicInfo.tsx

src/web/src/components/SignUp/Forms/GitHubAccount.tsx

src/web/src/components/SignUp/Forms/RSSFeeds.tsx

src/web/src/components/SignUp/Schema/FormSchema.tsx

src/web/src/pages/signup.tsx

DukeManh · 2021-04-15T16:56:44Z

@humphd Thanks for the review. I left some comments.

humphd · 2021-04-15T17:03:19Z

This needs a rebase.

*spinner *popups messages

action:? MouseEventHandler

popUp

*formmodel name to lower case *formModel Url -> URL *Array of steps commented.

huyxgit · 2021-04-18T17:30:08Z

kinda broken CSS in small screen.

PedroFonsecaDEV · 2021-04-18T17:36:10Z

kinda broken CSS in small screen.

@huynguyez
I need this to land to work on the CSS.
#2171 is waiting for this PR to land.

PedroFonsecaDEV added area: back-end area: front-end area: microservices labels Apr 14, 2021

PedroFonsecaDEV added this to the 2.0 Release milestone Apr 14, 2021

PedroFonsecaDEV requested review from humphd, chrispinkney and DukeManh April 14, 2021 23:38

PedroFonsecaDEV assigned DukeManh and PedroFonsecaDEV Apr 14, 2021

vercel bot deployed to Preview April 14, 2021 23:38 View deployment

humphd requested review from HyperTHD, huyxgit, rjayroso and yuanLeeMidori April 14, 2021 23:48

huyxgit suggested changes Apr 14, 2021

View reviewed changes

yuanLeeMidori reviewed Apr 15, 2021

View reviewed changes

HyperTHD requested changes Apr 15, 2021

View reviewed changes

PedroFonsecaDEV force-pushed the signup_1.4 branch from aa6fe21 to 42b512d Compare April 15, 2021 03:30

vercel bot deployed to Preview April 15, 2021 03:30 View deployment

yuanLeeMidori previously approved these changes Apr 15, 2021

View reviewed changes

humphd requested changes Apr 15, 2021

View reviewed changes

humphd mentioned this pull request Apr 15, 2021

Add /register route to auth service #2154

Merged

DukeManh and others added 15 commits April 18, 2021 12:58

Please squash all into 1 commit (#25)

a82ad0d

PopUp

6a6f249

remove redirect from AuthProvider

5fef63a

*fix vulnerability on PopUp

d378e8c

*spinner *popups messages

sign up working

5756524

Update TelescopeAvatar component:

8ad2e92

action:? MouseEventHandler

Avatar Logout Landing page

579b2f7

update banner buttons

e4c2add

popUp

update PopUp logic

fe67e97

update banner buttons

9394b1a

fix render behind pop up on signup

f2a94d9

text

bd6c12b

signup back to home button

ea3bba3

*github const rename

412368e

*formmodel name to lower case *formModel Url -> URL *Array of steps commented.

production.yml and fix button text

ca9d71f

PedroFonsecaDEV dismissed humphd’s stale review via ca9d71f April 18, 2021 16:59

PedroFonsecaDEV force-pushed the signup_1.4 branch from a4a69d4 to ca9d71f Compare April 18, 2021 16:59

vercel bot deployed to Preview April 18, 2021 16:59 View deployment

PedroFonsecaDEV requested review from humphd, yuanLeeMidori and HyperTHD April 18, 2021 16:59

tonyvugithub approved these changes Apr 18, 2021

View reviewed changes

huyxgit self-requested a review April 18, 2021 17:28

humphd approved these changes Apr 18, 2021

View reviewed changes

PedroFonsecaDEV merged commit 0299b0d into Seneca-CDOT:master Apr 18, 2021

humphd mentioned this pull request Apr 21, 2021

Fix styles on SignUp page. #2171

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SignUp Page #2148

SignUp Page #2148

PedroFonsecaDEV commented Apr 14, 2021

humphd commented Apr 14, 2021

huyxgit left a comment

PedroFonsecaDEV commented Apr 15, 2021

yuanLeeMidori left a comment •

edited

Loading

DukeManh commented Apr 15, 2021

HyperTHD left a comment

humphd left a comment

DukeManh commented Apr 15, 2021

humphd commented Apr 15, 2021

huyxgit commented Apr 18, 2021

PedroFonsecaDEV commented Apr 18, 2021 •

edited

Loading

SignUp Page #2148

SignUp Page #2148

Conversation

PedroFonsecaDEV commented Apr 14, 2021

Issue This PR Addresses

Type of Change

Description

Checklist

humphd commented Apr 14, 2021

huyxgit left a comment

Choose a reason for hiding this comment

PedroFonsecaDEV commented Apr 15, 2021

yuanLeeMidori left a comment • edited Loading

Choose a reason for hiding this comment

DukeManh commented Apr 15, 2021

HyperTHD left a comment

Choose a reason for hiding this comment

humphd left a comment

Choose a reason for hiding this comment

DukeManh commented Apr 15, 2021

humphd commented Apr 15, 2021

huyxgit commented Apr 18, 2021

PedroFonsecaDEV commented Apr 18, 2021 • edited Loading

yuanLeeMidori left a comment •

edited

Loading

PedroFonsecaDEV commented Apr 18, 2021 •

edited

Loading