Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth tests to more closely match signup requirements #2142

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Apr 14, 2021

Debugging the new signup flow with @PedroFonsecaDEV and @DukeManh last night made me realize I should expand the signup e2e test to better match what we do in the front-end.

I'm not 100% sure if this will work on all platforms, since I have to use http://host.docker.internal vs. http://localhost in the test. I want to see how it performs on CI.

@humphd
Copy link
Contributor Author

humphd commented Apr 14, 2021

Writing these tests was much more involved than I was planning on originally. To get this to work, I had to add an nginx container in development to serve static content to both the tests (http://localhost:8888) and the docker containers (http://test-web-content). I also had to make the e2e tests always run in sequence vs. parallel, because the auth/signup tests depend on shared user accounts, and updating the data in parallel tests at the same time leads to random test failures.

cc @birtony, who is thinking about configurations for Jest, and @c3ho who has to write tests for the parser service. The way I'm hosting the blog/feed in this PR could be used to test the parser service too, since it can connect to this web host running in docker to simulate download content. You can easily add more and different types of static content for new tests.

Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedro will file the signup page after this is landed.

@humphd humphd merged commit 37210f0 into Seneca-CDOT:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: microservices type: test Creation and development of test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants