Minor UI update #2137
Merged
Minor UI update #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroFonsecaDEV
requested review from
chrispinkney,
birtony,
DukeManh and
tonyvugithub
|
@chrispinkney @birtony @DukeManh @tonyvugithub @yuanLeeMidori lets take a look a this PR |
birtony
previously approved these changes
Apr 13, 2021
| style={{ | ||
| width: size, | ||
| height: size, | ||
| fontSize: `calc(${size} * 0.43)`, |
There was a problem hiding this comment.
We might want to do this calculation on line 26 and store the result in const, then pass it down
DukeManh
previously approved these changes
Apr 14, 2021
|
Rebasing and merging. |
BannerButtons update <TelescopeAvatar>
Update <TelescopeaAvatar>:
Add blog option.
Remove `padding-top`:
Class: postsWrapper inside <Posts>
Remove `padding-top` on mobile:
Class: postsWrapper inside <Posts>
Banner Button ScrollDown:
Working
PedroFonsecaDEV
force-pushed
the
ui_patch_1.9.6
branch
from
c36cf92 to
15f0a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
No open issue.
Type of Change
Description
This is a minor update to our UI:
1:
<TelescopeAvatar>size changed in<BannerButtons>.2: Updated
<TelescopeaAvatar>to receive blog and link to it (optional).3: Removed some extra spaces from our UI:
Removed
padding-topfor Desktop and mobile frompostsWrapperrendered by4: Banner Button ScrollDown: Is back to work. So users can use the
scroll-snapif available (@DukeManh is working on it) or use the button.Checklist