Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Jest plugin to Eslint config #2119

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Added Jest plugin to Eslint config #2119

merged 1 commit into from
Apr 11, 2021

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Apr 10, 2021

Issue This PR Addresses

Fixes #2118

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Configures eslint-plugin-jest. See the following screenshot of the /src/web/src/components/Logo.test.tsx file, no warnings anymore:
image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@birtony birtony added the developer experience Helping the Developer Experience label Apr 10, 2021
@birtony birtony added this to the 2.0 Release milestone Apr 10, 2021
@birtony birtony requested review from humphd and HyperTHD April 10, 2021 22:19
@birtony birtony self-assigned this Apr 10, 2021
@birtony birtony requested a review from Metropass April 10, 2021 22:53
@birtony birtony merged commit 30d94b9 into master Apr 11, 2021
@birtony birtony deleted the issue2118 branch April 11, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperTHD HyperTHD HyperTHD approved these changes

@humphd humphd humphd approved these changes

@Metropass Metropass Awaiting requested review from Metropass

Assignees

@birtony birtony

Labels
developer experience Helping the Developer Experience
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

Add Jest plugin to Eslint config
3 participants
@birtony @humphd @HyperTHD