Start to fix tests + add more factories #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rofreg is attempting to deploy a commit to the team-sendou-ink Team on Vercel. A member of the Team first needs to authorize it. |
rofreg
commented
Mar 31, 2021
Sendouc
reviewed
Apr 1, 2021
Sendouc
reviewed
Apr 1, 2021
|
For file naming camelCasing so prisma/factories/plus_status.ts -> prisma/factories/plusStatus.ts Once we get this merged I can fix the existing tests. The Plus Server side of the site has a bunch of edge cases anyway so I think it might be hard to figure out what's going on for someone else. Still a fan of this though! It's nice once we get some more dynamic seeded data. |
Sendouc
reviewed
Apr 1, 2021
Sendouc
reviewed
Apr 1, 2021
Co-authored-by: Kalle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #330 – this gets more tests passing, though not yet all. There's still more work to be done to either (1) make the factory data look exactly like the old fixtures, or (2) update the tests to use more dynamic factory data instead of assuming hard-coded values from fixtures.
Apparently
npm run migrate:resetinteracts poorly with Postgres, and effectively corrupts the connection of the running dev server such that you have to restart it. As a result, runningnpm run migrate:resetbetween each test was causing lots of problems.