[Buttons] fix for active basic button text color always having a lower specificity due to !important #5832
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r specificity due to !important
Closed
|
Yep, this is a bug. Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the starting style for color includes
!important, it always wins out against any value you set for@basicActiveTextColor.Semantic-UI/src/definitions/elements/button.less
Lines 705 to 708 in 796d2f6
This PR just adds
!important, which then makes it win because now the two compete with a level playing field and.ui.basic.active.buttonis higher than.ui.basic.button.It's not clear why
!importantis used in semantic, but I imagine it has a legitimate reason and the topic discussed ad nauseam, so I think this is likely the desired solution with the status quo.