vertically attached dropdown #3542
Conversation
add styling for top attached dropdown and bottom attached dropdown (similar to attached buttons)
|
Hi, you might also want to verify other attachments: table, menu, etc. as these get a bit complex. |
|
Yes, I will test the other elements & modules in the next time. For my use case I just needed the segment attached version and thought it might be a good extension for the framework. Thus I created the PR to find out if this is useful at all. |
to specify the exact closable behavior of a modal you can now set closable to ```click```to allow closing only by clicking on the dimmer or you can set it to ```escapeKey```to allow closing only by pressing the escape key.
…le-option' into vertically-attached-dropdown
|
From what I’ve tested—I copied the example above and tried appending dropdowns to the elements—it works as expected. The only problem is when an attached dropdown is placed between other attached elements like tables or segments, there’s a double border issue, which, I believe, can be fixed with something like that: .ui.attached + .ui.attached.dropdown:not(.bottom) {
margin-top: -1px;
}There’re an issue with attached menus being offset by 1px (#4248), maybe it’s better to deal with it first. Also, the fork was updated from the original, some merge bubbles appeared, and since it doesn’t exist anymore, this PR can’t be updated to remove them. EDIT: Found something else, when a dropdown is between other attached content and is opened .ui.attached + .ui.upward.selection.attached.dropdown:not(.bottom) {
border-radius: 0 !important;
} |
|
thank you for validation, @Banandrew :) If desired, you can use my changes for an own pr 😃 |
add styling for top attached dropdown and bottom attached dropdown
(similar to attached buttons)
example fiddle: http://jsfiddle.net/rr3Ltdzh/