Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup] 'SVGGraphicsElement' is undefined in IE 11 #3774

Closed
HitomiTenshi opened this issue Mar 1, 2016 · 1 comment
Closed

[Popup] 'SVGGraphicsElement' is undefined in IE 11 #3774

HitomiTenshi opened this issue Mar 1, 2016 · 1 comment
Milestone

Comments

@HitomiTenshi
Copy link
Contributor

Using the current next version (e9aca44) I encountered an error when adding popups to SVGCircleElements on IE 11. No errors on Firefox or Chrome.

Error: 'SVGGraphicsElement' is undefined
semantic.js (10387,13)

The line in question is:
if(target.width === 0 && target.height === 0 && SVGGraphicsElement && !(target.element instanceof SVGGraphicsElement)).

Changing it to:
if(target.width === 0 && target.height === 0 && (typeof SVGGraphicsElement === undefined) && !(target.element instanceof SVGGraphicsElement))

fixed the error for me and displayed the popup correctly on IE 11.

@jlukic jlukic added this to the 2.1.9 milestone Mar 4, 2016
@jlukic
Copy link
Member

jlukic commented Mar 4, 2016

Thanks, related #3043

jlukic added a commit that referenced this issue Mar 7, 2016
jlukic added a commit that referenced this issue Mar 7, 2016
@jlukic jlukic closed this as completed Mar 7, 2016
@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants