Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding components from semantic.css and avoid building individual component css #1501

Closed
montecruiseto opened this issue Dec 23, 2014 · 7 comments

Comments

@montecruiseto
Copy link
Contributor

Hi, I'm starting on SemUI and it looks amazing. A real Bootstrap killer for me. Congrats on a heroic effort so far @jlukic.

2 questions though:
During gulp install I switched off several components in the wizard, but all the components still end up in my semantic.css builds for some reason. I've read everything on the Learn Semantic site a couple of times now, and dug into the gulpfile. I cannot find the answer to:

  1. what is the best practice to throw out components to make the semantic.css really small? The only solution I found so far is to delete components from the semantic.json.
  2. what is the best practice to avoid building all the individual component css files all the time? They make builds quite long and I don't see any reason to ever use anything else than a concatenated semantic.css file (which I have customized to my liking by throwing out everything I don't need).
@jlukic
Copy link
Member

jlukic commented Dec 23, 2014

The JSON extends a default json template file semantic.json.example it appears in 6455fce when components were added to the default file, extending the default file would add unwanted components.

I'll fix this in ``1.4.1` today

@jlukic
Copy link
Member

jlukic commented Dec 23, 2014

Fixed in release later today

@montecruiseto
Copy link
Contributor Author

@jlukic Thanks!
Whats the best way to update though? I had semantic as a bower dependency but bower update basically wiped out everything for me, a full reset.

@montecruiseto
Copy link
Contributor Author

@jlukic so today I went ahead and did bower update to 1.5.0. Here's the path I took since I don't see a better way at this time:

  1. The whole semantic-ui folder gets overwritten with a new one. So I made a backup copy of the original semantic-ui directory first.
  2. ran npm install on the new directory
  3. ran gulp followed by choosing automatic setup
  4. Then I dropped my old semantic.json, theme.config and my own package theme directory in the new semantic-ui folder.

I assume I'm making a detour? I would appreciate to hear your thoughts on this!

@montecruiseto
Copy link
Contributor Author

and found out that components now can no longer be in semantic.json and have to be selected/commented-out in default.js
Never a dull moment here ;-)

@jlukic
Copy link
Member

jlukic commented Dec 31, 2014

Components should be read from semantic.json. It should only read defaults if no components are defined
https://github.com/Semantic-Org/Semantic-UI/blob/master/gulpfile.js#L133

@jlukic
Copy link
Member

jlukic commented Jan 1, 2015

@montecruiseto For discussion of issues with Bower and NPM see #1385. Bower and NPM both want you to treat the package folder as the same as a temp/ folder which means themes get razed.

We need to retool build tools to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants