#4163 #4164 More general fix that properly escapes string values for …

…selectors
Semantic-Org · Feb 21, 2017 · 6f19675 · 6f19675
1 parent 9be5cf2
commit 6f19675
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -263,12 +263,6 @@ $.fn.form = function(parameters) {
               }
             });
             return allValid;
-          },
-          validHTMLID(value) {
-            if(typeof value !== 'string') {
-              return false;
-            }
-            return value.search(regExp.htmlID) !== -1;
           }
         },
 
@@ -485,7 +479,8 @@ $.fn.form = function(parameters) {
           },
           field: function(identifier) {
             module.verbose('Finding field with identifier', identifier);
-            if(module.is.validHTMLID(identifier) && $field.filter('#' + identifier).length > 0 ) {
+            identifier = module.escape.string(identifier);
+            if($field.filter('#' + identifier).length > 0 ) {
               return $field.filter('#' + identifier);
             }
             else if( $field.filter('[name="' + identifier +'"]').length > 0 ) {
@@ -600,10 +595,11 @@ $.fn.form = function(parameters) {
 
           field: function(identifier) {
             module.verbose('Checking for existence of a field with identifier', identifier);
+            identifier = module.escape.regExp(identifier);
             if(typeof identifier !== 'string') {
               module.error(error.identifier, identifier);
             }
-            if(module.is.validHTMLID(identifier) && $field.filter('#' + identifier).length > 0 ) {
+            if($field.filter('#' + identifier).length > 0 ) {
               return true;
             }
             else if( $field.filter('[name="' + identifier +'"]').length > 0 ) {
@@ -617,6 +613,13 @@ $.fn.form = function(parameters) {
 
         },
 
+        escape: {
+          string: function(text) {
+            text =  String(text);
+            return text.replace(regExp.escape, '\\$&');
+          }
+        },
+
         add: {
           prompt: function(identifier, errors) {
             var