Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup): do not hide Popup with "hideOnScroll" when scroll comes from inside the Popup #4337

Merged

Conversation

oskarwrobel
Copy link
Contributor

Fixes an issue when Popup with hideOnScroll property hides on a scroll that comes from inside the Popup.
Closes #4305.

@welcome
Copy link

welcome bot commented Feb 16, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #4337 (572483c) into master (50f2952) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4337   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3245     3248    +3     
=======================================
+ Hits         3237     3240    +3     
  Misses          8        8           
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.93% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8a00e...572483c. Read the comment docs.

@layershifter
Copy link
Member

layershifter commented Feb 17, 2022

@oskarwrobel thanks for contributing ❤️ I tested on deployed doc site:
It still closes on scrolling inside... Can you please check

EDIT: NVM, it's a different case.

@layershifter layershifter merged commit fcbf7e2 into Semantic-Org:master Feb 17, 2022
@welcome
Copy link

welcome bot commented Feb 17, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@oskarwrobel oskarwrobel deleted the fix/popup-hideonscroll branch February 17, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup with hideOnScroll option hides on a scroll from inside the Popup
3 participants