Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): set a default activePage in Pagination's state #4037

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

gcalica
Copy link
Contributor

@gcalica gcalica commented Aug 15, 2020

Fixes #4035

On the first render of a Pagination, if there was no activePage or defaultActivePage value specified, activePage is undefined for "Previous Item" and "Next Item" PaginationItems. This PR sets an initial state for activePage.

@welcome
Copy link

welcome bot commented Aug 15, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #4037 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4037   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3275     3276    +1     
=======================================
+ Hits         3270     3271    +1     
  Misses          5        5           
Impacted Files Coverage Δ
src/addons/Pagination/Pagination.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebdb893...d50e6bc. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️

@layershifter layershifter merged commit 4dba2f1 into Semantic-Org:master Aug 16, 2020
@welcome
Copy link

welcome bot commented Aug 16, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination: Received NaN for the 'value' attribute
3 participants