Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update warning about using yarn #3816

Merged

Conversation

chrisbrainerd
Copy link
Contributor

Old warning was out of date - updated with something friendlier and more current. Fixes #3784

@welcome
Copy link

welcome bot commented Oct 22, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@azalisa
Copy link

azalisa commented Oct 27, 2019

Found this PR because I am affected by issue #3784, but I think you may have linked to it by mistake? The issue that seems to me like the best fit for this PR is issue #3815.

@chrisbrainerd
Copy link
Contributor Author

Yupppp - thank you 🙃
I was also thinking of looking at that one and had the tab open, sorry about that!

@levithomason
Copy link
Member

👍 !

@levithomason levithomason changed the title Changed warning about using yarn to be more up to date docs: update warning about using yarn Dec 8, 2019
@levithomason levithomason merged commit b5d46f9 into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@charliematters
Copy link
Contributor

charliematters commented Dec 8, 2019

I raised #3784, and I suspect that this PR doesn't fix it? #3784 has been marked as closed now though - do you mind if I reopen it?

@charliematters
Copy link
Contributor

@levithomason So I can't re-open it and I don't want to add a duplicate issue. Can you re-open it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The docs (https://react.semantic-ui.com) cause excessive CPU usage in Chrome
4 participants