-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Popup): add positionFixed
to support fixed mode in Popper.JS
#3760
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b15bce5
feat(Popup): add positionFixed to support popper fixed mode (#3718)
fxOne 7eca657
feat(Popup): add `positionFixed` to support fixed mode in `Popper.JS`
fxOne 753131d
Merge branch 'master' into master
layershifter 398a4ce
Update Popup-test.js
layershifter f620ca0
Update Popup.d.ts
layershifter 71b3476
Update Popup.js
layershifter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -127,6 +127,9 @@ export default class Popup extends Component { | |||||
/** Position for the popover. */ | ||||||
position: PropTypes.oneOf(positions), | ||||||
|
||||||
/** Enables the popper position 'fixed' mode */ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
positionFixed: PropTypes.bool, | ||||||
|
||||||
/** An object containing custom settings for the Popper.js modifiers. */ | ||||||
popperModifiers: PropTypes.object, | ||||||
|
||||||
|
@@ -333,6 +336,7 @@ export default class Popup extends Component { | |||||
pinned, | ||||||
popperModifiers, | ||||||
position, | ||||||
positionFixed, | ||||||
trigger, | ||||||
} = this.props | ||||||
const { closed, portalRestProps } = this.state | ||||||
|
@@ -369,6 +373,7 @@ export default class Popup extends Component { | |||||
eventsEnabled={eventsEnabled} | ||||||
modifiers={modifiers} | ||||||
placement={positionsMapping[position]} | ||||||
positionFixed={positionFixed} | ||||||
referenceElement={referenceElement} | ||||||
> | ||||||
{this.renderContent} | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.