-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mixed): renamed unsafe lifecycle methods #3747
chore(mixed): renamed unsafe lifecycle methods #3747
Conversation
Executed via `npx react-codemod rename-unsafe-lifecycles --parser babel` Disabled lint issues for updated lines. Closes Semantic-Org#3741 Related to Semantic-Org#2732
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3747 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 175 175
Lines 3125 3125
=======================================
Hits 3120 3120
Misses 5 5
Continue to review full report at Codecov.
|
Additional info: only the Also, most of the files were skipped (asuming they did not need a change). |
@jmyrland thank you for taking this ❤️ I updated PR with |
Nice @layershifter 👍 Kudos for all the effort in making condributions "newb-friendly" 😁 Really easy to get up and running with the project & ready to contribute 👌 As for the failing tests - I'm not sure whats causing this, but I see you "fixed" it by disabling some of the tests. Let me know if you need anything else from my end 👍 |
😍
Yea, I don't have any idea why they fails |
Executed via
npx react-codemod rename-unsafe-lifecycles --parser babel
Disabled lint issues for updated lines.
The changes should mitigate the "Unsafe lifecycle" warnings.
Closes #3741
Related to #2732