-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make get started instructions around themes more clear #3713
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 99.84% 99.83% -0.01%
==========================================
Files 178 175 -3
Lines 3150 3120 -30
==========================================
- Hits 3145 3115 -30
Misses 5 5
Continue to review full report at Codecov.
|
I really like the split here in explanations 👍 Keep it coming. |
Hi @levithomason let me know if you want to see anything else added/changed. I'm happy to jump on it. |
Codecov Report
@@ Coverage Diff @@
## master #3713 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 184 184
Lines 3218 3218
=======================================
Hits 3213 3213
Misses 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified markup a bit, LGTM 👍
I think this looks good. Just did a casual check, was hoping I could get more eyes on it.
Thanks in advance ❤️