Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): support IE11, fix scrolling glitches #3679

Merged
merged 9 commits into from
Jul 7, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 23, 2019

IE11 support

Fixes #3388.
Previously we missed support for legacy mode for Modals in SUI 2.4.0, this PR adds that support.

Scrolling glitches

Fixes #2221.
This PR ports fit() function from SUI which has more accurate computations than our existing check:

const scrolling = height > window.innerHeight

centered={false}

Fixes #2891.
Fixes #3669.
This case is also covered with ported fit() function.

@codecov-io
Copy link

codecov-io commented Jun 23, 2019

Codecov Report

Merging #3679 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3679      +/-   ##
==========================================
+ Coverage   99.83%   99.83%   +<.01%     
==========================================
  Files         174      175       +1     
  Lines        3103     3116      +13     
==========================================
+ Hits         3098     3111      +13     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <100%> (ø) ⬆️
src/modules/Modal/utils/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087593c...3c4ee28. Read the comment docs.

@layershifter layershifter merged commit c884fa9 into master Jul 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/modal-scrolling branch July 7, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants