fix(Modal): support IE11, fix scrolling glitches #3679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 support
Fixes #3388.
Previously we missed support for
legacy
mode forModal
s in SUI 2.4.0, this PR adds that support.Scrolling glitches
Fixes #2221.
This PR ports
fit()
function from SUI which has more accurate computations than our existing check:centered={false}
Fixes #2891.
Fixes #3669.
This case is also covered with ported
fit()
function.