perf(docs): improve rendering performance of example's pages #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…React into improve/perf # Conflicts: # docs/src/components/ComponentDoc/ComponentDoc.js
…React into improve/perf # Conflicts: # docs/src/components/ComponentDoc/ComponentControls/ComponentControls.js # docs/src/components/ComponentDoc/ComponentControls/ComponentControlsCodeSandbox.js # docs/src/components/ComponentDoc/ComponentExample/ComponentExampleRenderEditor.js # docs/src/components/ComponentDoc/ComponentExample/ComponentExampleRenderSource.js # docs/src/components/ComponentDoc/ComponentProp/ComponentPropEnum.js # docs/src/components/ComponentDoc/ComponentProp/ComponentPropEnumValue.js # docs/src/components/ComponentDoc/ComponentProp/ComponentPropFunctionSignature.js # docs/src/components/ComponentDoc/ComponentProp/ComponentPropHeader.js # docs/src/components/ComponentDoc/ComponentProps/ComponentPropsComponents.js # docs/src/components/ComponentDoc/ComponentSidebar/ComponentSidebar.js # docs/src/components/ComponentDoc/ComponentTable/ComponentTableHeader.js
…React into improve/perf # Conflicts: # docs/src/components/ComponentDoc/ComponentProps/ComponentProps.js # docs/src/components/ComponentDoc/ComponentSidebar/ComponentSidebarSection.js
…React into improve/perf # Conflicts: # docs/src/components/ComponentDoc/ComponentProps/ComponentProps.js # docs/src/components/ComponentDoc/ComponentSidebar/ComponentSidebarSection.js
Codecov Report
@@ Coverage Diff @@
## master #3549 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 174 174
Lines 2730 2730
=======================================
Hits 2725 2725
Misses 5 5Continue to review full report at Codecov.
|
…React into improve/perf # Conflicts: # docs/src/components/CodeEditor/CodeEditor.js # docs/src/components/CodeSnippet/CodeSnippet.js # docs/src/pages/Usage.mdx
mbakiev
pushed a commit
to mbakiev/Semantic-UI-React
that referenced
this pull request
Jun 17, 2019
…c-Org#3549) * wip * Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-React into improve/perf # Conflicts: # docs/src/components/ComponentDoc/ComponentProps/ComponentProps.js # docs/src/components/ComponentDoc/ComponentSidebar/ComponentSidebarSection.js * restore changes * clean up * restore changes * clean up * optimizations * add note * update usage page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on improving docs usage experience.
Extra responsive pages
Performance is gained by using placeholders for invisible components.
Each page is loading extra fast now 🚀
Simplify component controls
I removed
Show HTMLcontrol as it was done in Stardust by two reasons:Sidebar is fixed 🔨
Docs sidebar was moved to a higher level and now it will be not remounted on page switch.