Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): update handling of onClick for ellipsisItem #3493

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

layershifter
Copy link
Member

Fixes #3490.

Allows to correctly handle onClick on ellipsisItem:

<Pagination
  defaultActivePage={5}
  ellipsisItem={{
    content: '...',
    onClick: (e, props) => console.log('ellipsisItem click', props),
  }}
  totalPages={10}
/>

@codecov-io
Copy link

Codecov Report

Merging #3493 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3493      +/-   ##
==========================================
- Coverage   99.82%   99.82%   -0.01%     
==========================================
  Files         172      172              
  Lines        2805     2804       -1     
==========================================
- Hits         2800     2799       -1     
  Misses          5        5
Impacted Files Coverage Δ
src/addons/Pagination/PaginationItem.js 100% <100%> (ø) ⬆️
src/addons/Pagination/Pagination.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e382e...4485180. Read the comment docs.

@layershifter layershifter merged commit a0c71d9 into master Mar 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/pagination-click branch March 12, 2019 17:46
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants