Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Transition): allow custom animations #3438

Merged

Conversation

jongsue
Copy link
Contributor

@jongsue jongsue commented Feb 14, 2019

Fixes #3323.

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #3438 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3438   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         172      172           
  Lines        2819     2819           
=======================================
  Hits         2817     2817           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Transition/Transition.js 100% <100%> (ø) ⬆️
src/modules/Transition/TransitionGroup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5002...9924bd8. Read the comment docs.

@layershifter layershifter changed the title feat(Transition): custom animations(#3323) feat(Transition): allow custom animations Feb 17, 2019
@layershifter
Copy link
Member

Added small styling changes, LGTM! Good job 👍

@layershifter layershifter merged commit 3f81bfc into Semantic-Org:master Feb 19, 2019
@jongsue
Copy link
Contributor Author

jongsue commented Feb 19, 2019

Thank you for review @layershifter 👍

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants