feat(Responsive): re render only on visibility or props change #3274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of computing
isVisible()
on render, it's better to have its value in the state, as it avoids:shouldComponentUpdate
logicwidth
change, when its value is only used to check if it's visibleBy having
isVisible
in state, the component only renders when you updateisVisible
and when props change. I also made sure thatisVisible
is recomputed if the props it depends on change.