Update Menu to v1 API

[awei01]

Semantic-UI allows menu items with the class header to be <div>. Change behavior to allow header property that will then render a <div>. If MenuItem has header and href prop, then, render <a> tag.

[codecov-io]

Current coverage is 88.33%

Merging #319 into master will increase coverage by 0.02%

@@             master       #319   diff @@
==========================================
  Files            62         62          
  Lines           821        823     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            725        727     +2   
  Misses           96         96          
  Partials          0          0          

Powered by Codecov. Last updated by 44c796f...556c5de

[levithomason]

Thanks for the PR. The Menu component is scheduled to be updated to our v1 API pattern, see #269. The concern I have is that if I release this header update, it will be immediately over turned by the Menu API update.

The CONTRIBUTING.md guide details how to go about designing a component API. The Spec out the API section is of primary importance here. There are also a number of great example PRs to reference linked in #269.

Would you be interested in updating the Menu component's API entirely?

[awei01]

Not sure what your timeline is, but I can certainly contribute. I'll start with specs. Closing this PR for now.

[levithomason]

You'll see in the contributing guide that we'd love to have the spec right here in the PR. Feel free to re-open and use the PR description or comments for the spec! ;)

[awei01]

Ok this is a huge component... I'll give it a whirl, but please forgive any glaring oversights.

[levithomason]

If it seems like a bit much to bite off at once, I can whip up the first spec and we can iterate from there. LMK.

[awei01]

Menu API Proposal

This is really just to get the ball rolling...

<Menu>
    ...
</Menu>

<div class="ui menu">
    ...
</div>

[levithomason]

Types

All the Menu Types will follow this pattern, so we can just spec the one and extrapolate it to all Types: secondary pointing tabular text vertical pagination.

<Menu secondary>
  ...
</Menu>

<div class="ui secondary  menu">
  ...
</div>

[levithomason]

We should address #142 in this PR as well.

[awei01]

@levithomason Sorry, but I won't be able to contribute as much time as I had hoped.

[levithomason]

OK, thanks for the note. I'll close this PR for now. Let me know if you decide to pick it back up later.