Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): webpack 3 App direct import description #2929

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

bmbarker90
Copy link
Contributor

It appears that in #2561 the decision was made to switch to using babel-plugin-lodash, but the description of how direct imports are handled was not updated

It appears that in Semantic-Org#2561 the decision was made to switch to using babel-plugin-lodash, but the description of how direct imports are handled was not updated
@welcome
Copy link

welcome bot commented Jun 20, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@bmbarker90 bmbarker90 changed the title Fix App component description of direct imports Fix webpack 3 example's App component description of direct imports Jun 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #2929 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2929   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         161      161           
  Lines        2734     2734           
=======================================
  Hits         2725     2725           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43793ae...86a89fd. Read the comment docs.

@levithomason levithomason changed the title Fix webpack 3 example's App component description of direct imports fix(examples): webpack 3 App direct import description Jun 21, 2018
@levithomason levithomason merged commit 3a594ba into Semantic-Org:master Jun 21, 2018
@welcome
Copy link

welcome bot commented Jun 21, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@bmbarker90 bmbarker90 deleted the patch-1 branch June 21, 2018 14:14
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants