Divider Component updated to v1 API #268
Conversation
jhchill666
commented
Jun 22, 2016
jhchill666
commented
- Divider Component updated to v1 API
- Documents updated to reflect
- Divider-test added to suite
- Divider Component updated to v1 API - Documents updated to relect - Divider-test added to suite
Current coverage is 85.55%
|
|
|
||
| return ( | ||
| <DividerComponent className={classes} {...rest}> | ||
| {_children} |
There was a problem hiding this comment.
Can we use the children directly here? Not sure why the fragment is required.
There was a problem hiding this comment.
Of course. I'd just whittled down the Label version, and not considered createFragment was now redundant
|
Wow, nice work! Thanks. Just the one question about the fragment then we can merge this guy. |
| import * as common from 'test/specs/commonTests' | ||
|
|
||
| describe('Divider', () => { | ||
| common.isConformant(Divider) |
There was a problem hiding this comment.
Let's add common.rendersChildren and common.hasUIClassName.
There was a problem hiding this comment.
There are also common tests for the classNames, reference https://github.com/TechnologyAdvice/stardust/blob/master/test/specs/elements/Label/Label-test.js
|
Ok there you have it @levithomason |
|
👍 |
|
I've added #269 to track the remaining components needing updated. I've also added a section to the README outlining "How can I help?". Your PR was much appreciated, would love to see more! |
