-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(typings): add new types #1782
Conversation
@levithomason we have following validator: export const itemShorthand = (...args) => every([
disallow(['children']),
PropTypes.oneOfType([
PropTypes.array,
PropTypes.node,
PropTypes.object,
]),
])(...args) However, I don't remember any case when |
…React into style/-newtypings-types
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
=========================================
Coverage ? 99.75%
=========================================
Files ? 145
Lines ? 2474
Branches ? 0
=========================================
Hits ? 2468
Misses ? 6
Partials ? 0
Continue to review full report at Codecov.
|
07a3a37
to
d29aec5
Compare
d29aec5
to
0f864c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levithomason Ready for review, also please pay attention to the question above.
…React into style/-newtypings-types
…antic-UI-React into style/-newtypings-types
I went back and checked some old issues and discussions around this. I think we can remove the array type from |
…React into style/new-types
@levithomason you have already removed it in the |
Released in |
Fixes #1289.
This PR:
propTypes
.