Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Table): add sortable table example #1594

Merged
merged 3 commits into from
Apr 18, 2017

Conversation

josie11
Copy link
Contributor

@josie11 josie11 commented Apr 18, 2017

Add an example using sortable and sorted props to sort a Table's data. Fixes #1195

@codecov-io
Copy link

codecov-io commented Apr 18, 2017

Codecov Report

Merging #1594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1594   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2384     2384           
=======================================
  Hits         2378     2378           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a43956...a7ef3c7. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josie11 Thanks for PR 👍 I've made some style updates and changed the position of this example like in SUI docs.

@levithomason
Copy link
Member

I added the fixed prop to keep the table column widths stationary while sorting. Will merge on pass. Thanks folks!

@levithomason levithomason merged commit 40924fb into Semantic-Org:master Apr 18, 2017
@josie11 josie11 deleted the table-sort-docs branch April 18, 2017 17:51
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants