-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button: redundant prop in Vertical Group example #1697
Labels
Comments
@andreipfeiffer Thanks for report, looks like a copy-paste issue. We should simply remove |
layershifter
changed the title
fix(Button): Vertical Group
Button: redundant prop in Vertical Group example
May 23, 2017
Glad to help. |
@layershifter I want to create a PR for this. Is this an accepted commit message? |
@andreipfeiffer "docs(Button): remove redundant prop in Vertical Group example" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce
Expected
The last button (bottom) from the vertical group should have the top-left corner not rounded.
Result
Instead, it is rounded.
Testcase
https://react.semantic-ui.com/elements/button#button-example-group-vertical
Possible fix
The problem seams to be related to the fact that the parent has the classes
top attached
.Those classes are used apparently by the Vertically Attached examples.
If you remove
attached='top'
from the example, it looks fine.The text was updated successfully, but these errors were encountered: