feat(Embed): disable "related videos" when brandedUI is set to `tru…

…e` (#2320) * disables YouTube "related videos" when `brandedUI` is set to `true` * mixed(Embed): update tests and examples * style(Embed): add trailing dot
Semantic-Org · Nov 15, 2017 · bf27992 · bf27992
1 parent 6ef5af5
commit bf27992
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/docs/app/Examples/modules/Embed/Usage/EmbedExampleIframe.js b/docs/app/Examples/modules/Embed/Usage/EmbedExampleIframe.js
@@ -4,7 +4,6 @@ import { Embed } from 'semantic-ui-react'
 const EmbedExampleIframe = () => (
   <Embed
     autoplay={false}
-    brandedUI={false}
     color='white'
     hd={false}
     id='gJscrxxl_Bg'

diff --git a/docs/app/Examples/modules/Embed/Usage/EmbedExampleSettings.js b/docs/app/Examples/modules/Embed/Usage/EmbedExampleSettings.js
@@ -4,7 +4,7 @@ import { Embed } from 'semantic-ui-react'
 const EmbedExampleSettings = () => (
   <Embed
     autoplay={false}
-    brandedUI={false}
+    brandedUI
     color='white'
     hd={false}
     id='D0WnZyxp_Wo'

diff --git a/src/modules/Embed/Embed.d.ts b/src/modules/Embed/Embed.d.ts
@@ -36,7 +36,7 @@ export interface EmbedProps {
   /** Initial value of active. */
   defaultActive?: boolean;
 
-  /** Whether to show networks branded UI like title cards, or after video calls to action. */
+  /** Whether to prefer HD content. */
   hd?: boolean;
 
   /** Specifies an icon to use with placeholder content. */

diff --git a/src/modules/Embed/Embed.js b/src/modules/Embed/Embed.js
@@ -58,7 +58,7 @@ export default class Embed extends Component {
     /** Initial value of active. */
     defaultActive: PropTypes.bool,
 
-    /** Whether to show networks branded UI like title cards, or after video calls to action. */
+    /** Whether to prefer HD content. */
     hd: customPropTypes.every([
       customPropTypes.demand(['source']),
       PropTypes.bool,
@@ -136,6 +136,7 @@ export default class Embed extends Component {
         `&amp;hq=${hd}`,
         '&amp;jsapi=false',
         `&amp;modestbranding=${brandedUI}`,
+        `&amp;rel=${brandedUI ? 0 : 1}`,
       ].join('')
     }
 

diff --git a/test/specs/modules/Embed/Embed-test.js b/test/specs/modules/Embed/Embed-test.js
@@ -73,10 +73,15 @@ describe('Embed', () => {
   })
 
   describe('brandedUI', () => {
-    it('generates url part for source', () => {
+    it('generates "modestbranding" url parameter', () => {
       assertIframeSrc({ brandedUI: true }, '&amp;modestbranding=true')
       assertIframeSrc({ brandedUI: false }, '&amp;modestbranding=false')
     })
+
+    it('generates "rel" url parameter', () => {
+      assertIframeSrc({ brandedUI: true }, '&amp;rel=0')
+      assertIframeSrc({ brandedUI: false }, '&amp;rel=1')
+    })
   })
 
   describe('color', () => {