fix(Search): type definition for layout renderer (#4309)

* fix(Search): type definition for layout renderer * Apply suggestions from code review Co-authored-by: Oleksandr Fediashov <[email protected]>
Semantic-Org · Jan 14, 2022 · 8d4558a · 8d4558a
1 parent a8b5daf
commit 8d4558a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/modules/Search/Search.d.ts b/src/modules/Search/Search.d.ts
@@ -5,6 +5,7 @@ import { InputProps } from '../../elements/Input'
 import SearchCategory, { SearchCategoryProps } from './SearchCategory'
 import SearchResult, { SearchResultProps } from './SearchResult'
 import SearchResults from './SearchResults'
+import { SearchCategoryLayoutProps } from './SearchCategoryLayout'
 
 export interface SearchProps extends StrictSearchProps {
   [key: string]: any
@@ -61,11 +62,10 @@ export interface StrictSearchProps {
   /**
    * Renders the SearchCategory layout.
    *
-   * @param {object} categoryContent - The Renderable SearchCategory contents.
-   * @param {object} resultsContent - The Renderable SearchResult contents.
+   * @param {object} props - The SearchCategoryLayout props object.
    * @returns {*} - Renderable SearchCategory layout.
    */
-  categoryLayoutRenderer?: (props: SearchCategoryProps) => React.ReactElement<any>
+  categoryLayoutRenderer?: (props: Pick<SearchCategoryLayoutProps, 'categoryContent' | 'resultsContent'>) => React.ReactElement<any>
 
   /**
    * Renders the SearchCategory contents.

diff --git a/src/modules/Search/SearchCategory.d.ts b/src/modules/Search/SearchCategory.d.ts
@@ -1,6 +1,7 @@
 import * as React from 'react'
 
 import { SemanticShorthandContent } from '../../generic'
+import { SearchCategoryLayoutProps } from './SearchCategoryLayout'
 import SearchResult from './SearchResult'
 
 export interface SearchCategoryProps extends StrictSearchCategoryProps {
@@ -29,14 +30,10 @@ export interface StrictSearchCategoryProps {
   /**
    * Renders the SearchCategory layout.
    *
-   * @param {object} categoryContent - The Renderable SearchCategory contents.
-   * @param {object} resultsContent - The Renderable SearchResult contents.
+   * @param {object} props - The SearchCategoryLayout props object.
    * @returns {*} - Renderable SearchCategory layout.
    */
-  layoutRenderer?: (
-    categoryContent: React.ReactElement<any>,
-    resultsContent: React.ReactElement<any>,
-  ) => React.ReactElement<any>
+  layoutRenderer?: (props: Pick<SearchCategoryLayoutProps, 'categoryContent' | 'resultsContent'>) => React.ReactElement<any>
 
   /**
    * Renders the category contents.