Add forward ref to Form (#4364)

* Convert form to function component * Add ref forwarding to Form component * Update test/specs/collections/Form/Form-test.js Co-authored-by: Oleksandr Fediashov <[email protected]> Co-authored-by: Oleksandr Fediashov <[email protected]>
Semantic-Org · Dec 12, 2022 · 611b733 · 611b733
1 parent facd065
commit 611b733
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 46 deletions.
diff --git a/src/collections/Form/Form.js b/src/collections/Form/Form.js
@@ -1,7 +1,7 @@
 import cx from 'clsx'
 import _ from 'lodash'
 import PropTypes from 'prop-types'
-import React, { Component } from 'react'
+import React from 'react'
 
 import { getElementType, getUnhandledProps, SUI, useKeyOnly, useWidthProp } from '../../lib'
 import FormButton from './FormButton'
@@ -24,56 +24,54 @@ import FormTextArea from './FormTextArea'
  * @see Radio
  * @see Select
  */
-class Form extends Component {
-  handleSubmit = (e, ...args) => {
-    const { action } = this.props
-
+const Form = React.forwardRef(function (props, ref) {
+  const {
+    action,
+    children,
+    className,
+    error,
+    inverted,
+    loading,
+    reply,
+    size,
+    success,
+    unstackable,
+    warning,
+    widths,
+  } = props
+
+  const handleSubmit = (e, ...args) => {
     // Heads up! Third party libs can pass own data as first argument, we need to check that it has preventDefault()
     // method.
     if (typeof action !== 'string') _.invoke(e, 'preventDefault')
-    _.invoke(this.props, 'onSubmit', e, this.props, ...args)
+    _.invoke(props, 'onSubmit', e, props, ...args)
   }
 
-  render() {
-    const {
-      action,
-      children,
-      className,
-      error,
-      inverted,
-      loading,
-      reply,
-      size,
-      success,
-      unstackable,
-      warning,
-      widths,
-    } = this.props
-
-    const classes = cx(
-      'ui',
-      size,
-      useKeyOnly(error, 'error'),
-      useKeyOnly(inverted, 'inverted'),
-      useKeyOnly(loading, 'loading'),
-      useKeyOnly(reply, 'reply'),
-      useKeyOnly(success, 'success'),
-      useKeyOnly(unstackable, 'unstackable'),
-      useKeyOnly(warning, 'warning'),
-      useWidthProp(widths, null, true),
-      'form',
-      className,
-    )
-    const rest = getUnhandledProps(Form, this.props)
-    const ElementType = getElementType(Form, this.props)
-
-    return (
-      <ElementType {...rest} action={action} className={classes} onSubmit={this.handleSubmit}>
-        {children}
-      </ElementType>
-    )
-  }
-}
+  const classes = cx(
+    'ui',
+    size,
+    useKeyOnly(error, 'error'),
+    useKeyOnly(inverted, 'inverted'),
+    useKeyOnly(loading, 'loading'),
+    useKeyOnly(reply, 'reply'),
+    useKeyOnly(success, 'success'),
+    useKeyOnly(unstackable, 'unstackable'),
+    useKeyOnly(warning, 'warning'),
+    useWidthProp(widths, null, true),
+    'form',
+    className,
+  )
+  const rest = getUnhandledProps(Form, props)
+  const ElementType = getElementType(Form, props)
+
+  return (
+    <ElementType {...rest} action={action} className={classes} onSubmit={handleSubmit} ref={ref}>
+      {children}
+    </ElementType>
+  )
+})
+
+Form.displayName = 'Form'
 
 Form.propTypes = {
   /** An element type to render as (string or function). */

diff --git a/test/specs/collections/Form/Form-test.js b/test/specs/collections/Form/Form-test.js
@@ -34,6 +34,10 @@ describe('Form', () => {
     rendersContent: false,
   })
 
+  common.forwardsRef(Form, {
+    tagName: 'form',
+    requiredProps: { children: <input /> },
+  })
   common.implementsWidthProp(Form, [], {
     propKey: 'widths',
   })