Fix XPath crash issue in IEDriver #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
Signed-off by: jimevans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IEDriver XPath crash issue
Description
This PR is to fix XPath crash issue tracked in #9938
Motivation and Context
The XPath crash issue in IEDriver was caused by regex update from this commit: cf49ba23. The IEDriver crashed when IE (or Edge in IEMode) tried to parse the unicode regex ending with
/gu.Types of changes
In this PR, a browser type check is added to let IE (or Edge in IEMode) use
/gregex and other browsers use/guunicode regex in the file.In addition, this PR generated the file atoms.h to reflect the changes in javascript/atom and updated the file for IEDriver.