Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected conditions for invisibility of multiple elements #7496

Closed
wants to merge 2 commits into from
Closed

Add expected conditions for invisibility of multiple elements #7496

wants to merge 2 commits into from

Conversation

3j14
Copy link

@3j14 3j14 commented Aug 15, 2019

  • By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

  • invisibility_of_any_elements_located: Returns True once any of the located elements becomes invisible

  • invisibility_of_all_elements_located: Returns True once all of the located elements are invisible

@GQAssurance
Copy link
Contributor

My understanding is that the python maintainers are reluctant to expand python ECs beyond the ones already defined in Java.

#7406 is a PR which implements logical operators including OR and AND. Once #7406 is merged, coders could implement your PR's functionality for any combination of ECs, and not just for invisibility.

@p0deje p0deje added the C-py label Aug 19, 2019
@GQAssurance
Copy link
Contributor

@jnsdrtlf #7406 has been merged into master. Perhaps you can use its constructs, which could perhaps be more valuable than the changes suggested in this PR?

@kmcgon
Copy link

kmcgon commented Oct 22, 2019

I think this could also be achieved using the existing until_not() method in WebDriverWait.
Something like:
WebDriverWait(driver).until_not(expected_conditions. visibility_of_all_elements_located(my_locator))

@3j14
Copy link
Author

3j14 commented Oct 22, 2019

@kmcgon your suggested code would wait until one of the elements becomes invisible (invisibility_of_any_elements_located).

Sure, this would cover one of my ECs, but this pull request is discarded anyway ;)

@3j14 3j14 closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants