Add a check for WebExtension in the atoms userAgent #6475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDE requires specific treatments in atoms, that require the atoms to take WebExtensions into account, similarly to how it takes Firefox Extensions.
Right now we circumvent the issue by overriding
bot.userAgent.FIREFOX_EXTENSIONto be true, but that adds extra treatments in atoms that may assume XUL, which is why we need to define WebExtensions specifically.Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementThis change is