[build] properly get selenium manager from bazel output #13452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
commented
Jan 17, 2024
nvborisenko
requested changes
Jan 17, 2024
titusfortner
force-pushed
the
dotnet_build
branch
from
d6f671f to
eee6629
Compare
titusfortner
commented
Jan 18, 2024
titusfortner
force-pushed
the
dotnet_build
branch
from
eee6629 to
bfcb242
Compare
nvborisenko
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like .NET was hard coded to using the binaries in the repo even when we built them.
This is an attempt to get the binaries from the target output.