Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul project Readme #13338

Merged
merged 3 commits into from
Dec 21, 2023
Merged

overhaul project Readme #13338

merged 3 commits into from
Dec 21, 2023

Conversation

titusfortner
Copy link
Member

This started as documenting the Windows build steps now that you don't have to do the weird visual studio version workaround.

Then it turned into reorganizing the sections.

That turned into updating a bunch of things in the Rakefile.

I figured I'd ask for someone else to look at it before I just merged it. Thanks.

Hmm, I'm already seeing a few things I want to tweak more, but I've spent so much time on this already, lol... Let me know what you think.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions, thanks @titusfortner!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@titusfortner
Copy link
Member Author

I'm merging this. Let me know if I need to revert, better explain or add things that are missing.

@titusfortner titusfortner merged commit a6a2cd6 into trunk Dec 21, 2023
10 checks passed
@titusfortner titusfortner deleted the readme branch December 21, 2023 16:11

## Installing

These are the requirements to cereate your own local dev environment to contribute to Selenium.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo cereate --> create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants