[java] Ensure calling close() and quit() done cause BiDi websocket errors #13333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #13316
If the BiDi capability is passed, then WebDriver that implements HasBiDi interface, which will create the websocket connection for BiDi. So, on WebDriver quit(), those resources do need the clean up.
Motivation and Context
If WebDriver close() is called, it closes the session if it is the last browsing context. It also closes the WebSocket.
If WebDriver quit() is called after, it also tries to close an already closed websocket. The changes fix that.
This measure is needed until "session.end" from BiDi is implemented by the browsers, which can then be used to close the BiDi session. Similar, to what we do we CDP and dettach target.
Additionally, removed the status check while creating BiDi session, the status seems important if we create BiDi only session, which is not in scope for us currently.
Types of changes
Checklist