Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored log capture and formatting code in org.openqa.selenium.tes… #13322

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

manuelsblanco
Copy link
Contributor

…ting and org.openqa.selenium.grid.log packages.

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

I refactored the code related to log capture and formatting in the org.openqa.selenium.testing and org.openqa.selenium.grid.log packages. This involved restructuring existing classes and methods to improve code readability and maintainability.

Motivation and Context

This change is required to enhance the codebase's maintainability and improve the formatting of log messages in the org.openqa.selenium.testing and org.openqa.selenium.grid.log packages. The existing code needed refactoring to make it more readable and organized. Using a variable value instead an String.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @manuelsblanco!

@diemol diemol merged commit 273c3d4 into SeleniumHQ:trunk Dec 18, 2023
3 checks passed
@manuelsblanco manuelsblanco deleted the lineSeparator branch December 18, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants