Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Extract downloadable zip file in memory #13277

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Dec 9, 2023

Description

There is no need to put a zip file to disk.

Motivation and Context

Fixes #13276

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko
Copy link
Member Author

I am not sure we have unit tests for this, but I verified it via building the package and using it in examples repo. It passes.

@titusfortner titusfortner merged commit f22e08f into SeleniumHQ:trunk Dec 20, 2023
11 checks passed
@nvborisenko nvborisenko deleted the dotnet-zip-in-memory branch February 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dotnet] Avoid temp file when download file
2 participants