Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Fix nuget target framework #13253

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[dotnet] Fix nuget target framework #13253

merged 2 commits into from
Dec 6, 2023

Conversation

nvborisenko
Copy link
Member

Description

Fix incorrect tfm in nuget package v4.16.0

Motivation and Context

Fixes #13250

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko requested a review from shs96c December 6, 2023 11:49
shs96c
shs96c approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c shs96c merged commit 688345a into SeleniumHQ:trunk Dec 6, 2023
11 checks passed
@ms6073
Copy link

ms6073 commented Dec 6, 2023

Will the PR for this address issues with updating Nuget package references for test projects running under net7.x/8.x?
The following error was returned when trying to update Nuget package references this morning.

Package Selenium.Support 4.16.0 is not compatible with net7.0 (.NETCoreApp,Version=v7.0). Package Selenium.Support 4.16.0 supports: supportnetstandard20 (supportnetstandard2.0,Version=v0.0)

@nvborisenko
Copy link
Member Author

Yes.

@nvborisenko nvborisenko deleted the dotnet-fix-nuget branch December 6, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Selenium.Support 4.16.0 nuget is not valid
3 participants
@nvborisenko @ms6073 @shs96c